Fix multi models metric result in PromQL #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jeffwan
reviewed
Dec 2, 2024
| @@ -103,7 +103,7 @@ jobs: | |||
|
|
|||
| - name: Deploy Workload | |||
| run: | | |||
| cd docs/development/app | |||
There was a problem hiding this comment.
em. I think I forgot this change in last PR but ci didn't catch it due to the cost saving change recently. Let me resume all post-submit changes in CI to catch the change
Jeffwan
reviewed
Dec 2, 2024
| "instance": fmt.Sprintf("%s:%d", pod.Status.PodIP, podPort), | ||
| } | ||
| metric, ok := metrics.Metrics[metricName] | ||
| modelNames, ok := c.PodToModelMapping[pod.Name] |
There was a problem hiding this comment.
Technically, this might not be populated if pod just arrive. but I think this is ok, we may miss few metrics until the pod is added into the map.
gangmuk
pushed a commit
that referenced
this pull request
Jan 25, 2025
* fix: do promQL for multi models in one pod * fix startup yaml and mock app * fix: fix mock app dir in ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fix multi models metric result in PromQL. Traverse
PodToModelMappingto obtain allmodelNameson the podRelated Issues
Resolves: #423
Important: Before submitting, please complete the description above and review the checklist below.
Contribution Guidelines (Expand for Details)
We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:
Pull Request Title Format
Your PR title should start with one of these prefixes to indicate the nature of the change:
[Bug]: Corrections to existing functionality[CI]: Changes to build process or CI pipeline[Docs]: Updates or additions to documentation[API]: Modifications to aibrix's API or interface[CLI]: Changes or additions to the Command Line Interface[Misc]: For changes not covered above (use sparingly)Note: For changes spanning multiple categories, use multiple prefixes in order of importance.
Submission Checklist
By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.