Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autoscaler scalingstrategy switching logic #475

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

nwangfw
Copy link
Collaborator

@nwangfw nwangfw commented Dec 3, 2024

Pull Request Description

BugFix: We should use KPA rather than HPA in the ScalingStrategy.

Related Issues

Resolves: #474

Important: Before submitting, please complete the description above and review the checklist below.


Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to aibrix's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • PR title includes appropriate prefix(es)
  • Changes are clearly explained in the PR description
  • New and existing tests pass successfully
  • Code adheres to project style and best practices
  • Documentation updated to reflect changes (if applicable)
  • Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

@nwangfw nwangfw marked this pull request as ready for review December 3, 2024 23:58
@nwangfw nwangfw requested review from kr11 and Jeffwan December 4, 2024 00:55
@kr11 kr11 merged commit c6765bd into main Dec 4, 2024
10 checks passed
@kr11 kr11 deleted the gateway-updatemetrics-bugfix branch December 4, 2024 02:19
gangmuk pushed a commit that referenced this pull request Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect scalingstrategy in autoscaler
2 participants