[enhancement] GPU optimizer accumulated fix #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test case for make url created from metricSource as expected: endpoint should include port, if not and port is specified, port will be append to endpoint.
Fix an error in benchmark that may cause error when now all token_latencies might missing some data.
added 18 commits
January 9, 2025 15:50
Optimize update logic.
Reset benchmark as in main.
|
@nwangfw can you help review this PR? |
Signed-off-by: Jingyuan <[email protected]>
nwangfw
reviewed
Jan 27, 2025
Jeffwan
approved these changes
Jan 27, 2025
| images: | ||
| - name: aibrix/controller-manager | ||
| newName: aibrix-container-registry-cn-beijing.cr.volces.com/aibrix/controller-manager | ||
| newTag: v0.2.0-rc.1 |
There was a problem hiding this comment.
minor: we can use v0.2.0-rc.2 now. few issues fixed.
| resources: | ||
| - ../../../default | ||
| - ../../../gpu-optimizer |
There was a problem hiding this comment.
now, it installed single component instead of the default installation?
There was a problem hiding this comment.
Yes, previously, it installed all + specific debug version. I find it is not convenient to debug more than one components. Now, we just deploy the default, and apply debug components if needed.
nwangfw
approved these changes
Jan 27, 2025
Jeffwan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
2.1 For components created using "kubectl create -k config/default", older component must be deleted using "kubectl delete -k config/dev/xxxx" and then reapplied.
Related Issues
Resolves: #546
Important: Before submitting, please complete the description above and review the checklist below.
Contribution Guidelines (Expand for Details)
We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:
Pull Request Title Format
Your PR title should start with one of these prefixes to indicate the nature of the change:
[Bug]: Corrections to existing functionality[CI]: Changes to build process or CI pipeline[Docs]: Updates or additions to documentation[API]: Modifications to aibrix's API or interface[CLI]: Changes or additions to the Command Line Interface[Misc]: For changes not covered above (use sparingly)Note: For changes spanning multiple categories, use multiple prefixes in order of importance.
Submission Checklist
By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.