-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Improving the heterogenous-GPU feature doc #634
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do need the label "model.aibrix.ai/min_replicas" to make heterogenous GPU working. Consider a configuration of (0xA10, 5xL20), and minimum configuration (1xA10, 0xL20). If we set minReplicas of A10 deployment to 1, the (0xA10, 5xL20) configuration can't be applied.
5cc4126
to
a2ce701
Compare
Great example! I have added the old config back and also added some more explanation. Please help to review it @zhangjyr |
a2ce701
to
3d4d9ed
Compare
3d4d9ed
to
e5e4ac8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Pull Request Description
model.aibrix.ai/min_replicas
, how to configure it, and whyminReplia
defined in podAutoscaler doesn't work in heterogenous story.model.aibrix.ai/min_replicas
in sample/heterogenous yaml..note::
command doesn't work. Removed it from doc.Related Issues
Resolves: #[Insert issue number(s)]
Important: Before submitting, please complete the description above and review the checklist below.
Contribution Guidelines (Expand for Details)
We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:
Pull Request Title Format
Your PR title should start with one of these prefixes to indicate the nature of the change:
[Bug]
: Corrections to existing functionality[CI]
: Changes to build process or CI pipeline[Docs]
: Updates or additions to documentation[API]
: Modifications to aibrix's API or interface[CLI]
: Changes or additions to the Command Line Interface[Misc]
: For changes not covered above (use sparingly)Note: For changes spanning multiple categories, use multiple prefixes in order of importance.
Submission Checklist
By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.