[Hierarchical Queues]When creating a hierarchical sub-queue, it will be rejected by the Validating Webhook

[JesseStutler]

Description

  A
 /
B

For example, there are two queues to build the hierarchical queues, B is the child queue of A, and then B commits some podgroups, then queue B will update its allocated field in status, also its parent queue A. Then we try to create a sub-queue under A called C, then the creation of C will be rejected because of these codes:

   A
 /    \
B      C

volcano/pkg/webhooks/admission/queues/validate/validate_queue.go

Lines 259 to 262 in 444a1ab

	if allocated, ok := parentQueue.Status.Allocated[v1.ResourcePods]; ok && !allocated.IsZero() {
	return fmt.Errorf("queue %s cannot be the parent queue of queue %s because it has allocated Pods: %d",
	parentQueue.Name, queue.Name, allocated.Value())
	}

Steps to reproduce the issue

Describe the results you received and expected

We may not depend only on allocated field in queue status to check whether we can create a sub-queue under the existing queue, we may combine to check whether a queue is a leaf queue. Only leaf queue without pods inside can create sub-queues, there is no check of non-leaf queues.

What version of Volcano are you using?

v1.11

Any other relevant information

No response

[Monokaix]

/good-first-issue

[volcano-sh-bot]

@Monokaix:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tanberBro]

/assign