Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dynamic client to get annotations #3999

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Monokaix
Copy link
Member

@Monokaix Monokaix commented Feb 6, 2025

What type of PR is this?

/kind cleanup
/area controllers

What this PR does / why we need it:

Use dynamic client instead of swich case.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

@volcano-sh-bot volcano-sh-bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/controllers labels Feb 6, 2025
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign monokaix
You can assign the PR to them by writing /assign @monokaix in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 6, 2025
@hwdef
Copy link
Member

hwdef commented Feb 6, 2025

There may be performance issues with dynamic client.
We'd better run a performance test.

@Monokaix
Copy link
Member Author

Monokaix commented Feb 8, 2025

There may be performance issues with dynamic client. We'd better run a performance test.

That's a good point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/controllers kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants