fix: deoptimize slots when a directive is used #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vue-jsx-explorer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This comment was marked as outdated.
This comment was marked as outdated.
KaelWD
force-pushed
the
fix/541-slot-directives
branch
4 times, most recently
from
ca2e782 to
35b5a9c
Compare
KaelWD
force-pushed
the
fix/541-slot-directives
branch
from
35b5a9c to
2f75d2f
Compare
|
This is ready to merge. |
KaelWD
force-pushed
the
fix/541-slot-directives
branch
from
fc7ea37 to
e6cee1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What is the nature of this change?
🔗 Related Issue
fixes #541
💡 Background or solution
resolveDirectivein an optimized slot uses the child component's scope, so directives registered locally in the parent fail to resolve. To fix this we either need to hoistresolveDirectivetosetuplike vue/compiler-sfc does (not really possible in JSX), or disable slot optimization for all parents.resolveDirective will not be emitted for directives that are already in scope:
📝 Changelog
☑️ Self Check before Merge