Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dark mode to 3.4 docs #2685

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add dark mode to 3.4 docs #2685

wants to merge 1 commit into from

Conversation

mattgarrish
Copy link
Member

This matches the changes in #2672 for the 3.4 docs.

It also adds the css-inline code to the accessibility techniques. The rest already had it.

@mattgarrish mattgarrish requested a review from iherman February 19, 2025 14:33
Copy link
Member

@iherman iherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve it (of course), but we may want to reach out to the WG before we do such a change. It pretty much changes the outlook of the documents after all...

@wareid @shiestyle ?

@iherman iherman requested review from shiestyle and wareid February 19, 2025 14:56
@mattgarrish
Copy link
Member Author

It pretty much changes the outlook of the documents after all...

Sure, but this is W3C standard for dark mode, not something we've come up with (modulo the few tweaks).

No harm in checking, though. I was going to wait until you were ready to merge the other PR, anyway. It looks like it only captures the authoring spec right now, but we should probably republish everything under 3.3 with this change for consistency.

@iherman
Copy link
Member

iherman commented Feb 19, 2025

It pretty much changes the outlook of the documents after all...

Sure, but this is W3C standard for dark mode, not something we've come up with (modulo the few tweaks).

That is correct: it is standard if we decide to adopt dark mode. But dark mode is not required by the W3C publication rules. Hence, it is better to check with the WG, it should not be solely the editors' decision.

No harm in checking, though. I was going to wait until you were ready to merge the other PR, anyway.

You mean #2672? I think that one should be closed, and this PR takes it over. I do not think we should change 3.3 at this point. Let dark mode be the first feature that differentiate 3.4 from 3.3!

It looks like it only captures the authoring spec right now, but we should probably republish everything under 3.3 with this change for consistency.

You mean the other notes? Yes, of course.


I presume we plan to move (copy) all notes from the 3.3 subtree to the 3.4 one, right? So the dark mode versions of the notes would be, sort of, 3.4 (even if they do not really change).

@mattgarrish
Copy link
Member Author

it is standard if we decide to adopt dark mode

I don't think the decision is up to us. The announcement said this was coming to all specs this year or next, but we should add the meta tag to help with the transition: https://lists.w3.org/Archives/Public/spec-prod/2024AprJun/0000.html

No harm in letting the group know, but we can't really stop the change from coming.

I presume we plan to move (copy) all notes from the 3.3 subtree to the 3.4 one, right?

Oh, I was thinking we'd just do a final republish of everything in 3.3 and then only bring the notes forward to the 3.4 directory as we actually need to work on them.

But maybe it's better to copy them all forward in case there are other changes like this that need a full refresh of the notes. I'll defer to you on which approach you think is better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants