XML codec implemented #804
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fully codec implemented based on scala-xml liberary .
Open
|
@jdegoes adding support for native and tests as well . i am on it ! |
|
@jdegoes can i only go for jvm support for now since , in scala -xml the SAX APIs (for example, classes like org.xml.sax.EntityResolver and org.xml.sax.ErrorHandler), which are available on the JVM but not on Scala.js or Scala Native. In other words, even though Scala XML 2.3.0 is published for Scala Native (and Scala.js), certain XML parsing functionality (typically those based on the SAX parser) isn’t natively supported on those platforms. |
|
@harshtech123 This still needs a full and exhaustive test suite before consideration. Thank you! |
|
@jdegoes i am on it , we will implement this for jvm only and have fully end to end tests for assertions, thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This XML codec uses Scala-xml as dependency
this codec insures fully round trip , provide ability to encode and decode xml and supports every primitive and dynamic types
/claim #754
/closes #754