Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image scaling in documentation #254

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

wlcsm
Copy link
Contributor

@wlcsm wlcsm commented Jun 21, 2024

With the "scaling" attribute, images and gifs are assigned a fixed width and heigh at compile time which is included directly in the html - overwriting the rest of the style sheets which tell it to auto scale.

This caused images to be squished on mobile devices.

Before

After
Screenshot 2024-06-21 at 10 05 52 AM

@wlcsm wlcsm force-pushed the fix/docs-image-scaling branch from 6c1887b to 6c55b96 Compare June 21, 2024 09:08
With the "scaling" attribute, images and gifs are assigned a fixed width
and heigh at compile time which is included directly in the html -
overwriting the rest of the style sheets which tell it to auto scale.
This caused images to be squished on mobile devices.
@wlcsm wlcsm force-pushed the fix/docs-image-scaling branch from 6c55b96 to 44cffa7 Compare June 21, 2024 09:10
Copy link
Collaborator

@boldar99 boldar99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me as well on chrome and safari

@jvdwetering jvdwetering merged commit 26b265a into zxcalc:master Jun 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants