Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test](beut) add VDataStreamRecvr beut #48188

Merged
merged 2 commits into from
Feb 25, 2025

Conversation

Mryange
Copy link
Contributor

@Mryange Mryange commented Feb 21, 2025

What problem does this PR solve?

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Mryange
Copy link
Contributor Author

Mryange commented Feb 21, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 31400 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 602b92f38c90511e8aa35ae9606ee41d4706b1f4, data reload: false

------ Round 1 ----------------------------------
q1	17597	5331	5086	5086
q2	2064	299	165	165
q3	10537	1262	782	782
q4	10217	1034	538	538
q5	7563	2484	2350	2350
q6	192	171	133	133
q7	910	760	603	603
q8	9309	1368	1164	1164
q9	4903	4594	4685	4594
q10	6821	2310	1889	1889
q11	487	277	256	256
q12	353	356	217	217
q13	17788	3666	3041	3041
q14	225	228	207	207
q15	517	473	472	472
q16	635	612	576	576
q17	583	860	328	328
q18	6682	6238	6043	6043
q19	2033	991	558	558
q20	314	325	181	181
q21	2736	2142	1927	1927
q22	362	330	290	290
Total cold run time: 102828 ms
Total hot run time: 31400 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5202	5088	5124	5088
q2	237	338	229	229
q3	2145	2656	2330	2330
q4	1464	1864	1396	1396
q5	4248	4147	4125	4125
q6	211	165	127	127
q7	1855	1795	1709	1709
q8	2624	2660	2549	2549
q9	7301	7180	7168	7168
q10	3077	3198	2794	2794
q11	569	535	492	492
q12	680	784	613	613
q13	3391	3893	3273	3273
q14	283	299	266	266
q15	524	459	460	459
q16	667	695	640	640
q17	1131	1659	1287	1287
q18	7564	7451	7346	7346
q19	788	813	915	813
q20	1965	2030	1875	1875
q21	5482	4886	4822	4822
q22	598	551	514	514
Total cold run time: 52006 ms
Total hot run time: 49915 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 190368 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 602b92f38c90511e8aa35ae9606ee41d4706b1f4, data reload: false

query1	1325	954	939	939
query2	6292	1873	1799	1799
query3	11109	4601	4586	4586
query4	56134	24845	23492	23492
query5	5088	574	484	484
query6	365	193	185	185
query7	5079	507	289	289
query8	318	262	232	232
query9	6026	2601	2619	2601
query10	428	307	261	261
query11	15164	15054	14861	14861
query12	151	104	105	104
query13	1128	498	375	375
query14	10625	6759	6155	6155
query15	213	200	190	190
query16	7142	673	479	479
query17	1043	727	554	554
query18	1510	406	307	307
query19	193	210	159	159
query20	128	124	119	119
query21	208	126	103	103
query22	4450	4409	4234	4234
query23	33855	33796	34059	33796
query24	5695	2440	2434	2434
query25	469	468	398	398
query26	689	280	157	157
query27	1759	518	338	338
query28	2787	2456	2419	2419
query29	556	565	425	425
query30	210	193	162	162
query31	909	861	849	849
query32	104	61	63	61
query33	455	364	292	292
query34	758	883	510	510
query35	780	851	750	750
query36	971	998	895	895
query37	123	98	73	73
query38	4273	4317	4186	4186
query39	1494	1446	1469	1446
query40	209	117	114	114
query41	59	51	51	51
query42	131	111	110	110
query43	512	512	477	477
query44	1297	797	787	787
query45	219	173	165	165
query46	894	1067	698	698
query47	1848	1875	1801	1801
query48	401	420	310	310
query49	691	522	408	408
query50	729	752	423	423
query51	4269	4339	4231	4231
query52	110	104	89	89
query53	227	277	189	189
query54	484	486	451	451
query55	85	78	82	78
query56	251	271	281	271
query57	1168	1178	1108	1108
query58	246	235	253	235
query59	2841	2833	2786	2786
query60	286	276	277	276
query61	124	124	140	124
query62	712	749	672	672
query63	236	193	197	193
query64	1534	1104	771	771
query65	3183	3141	3138	3138
query66	715	408	311	311
query67	16025	15467	15323	15323
query68	2746	783	534	534
query69	491	308	276	276
query70	1221	1075	1119	1075
query71	343	304	268	268
query72	6504	3553	3702	3553
query73	646	746	350	350
query74	9302	9159	8925	8925
query75	3117	3167	2845	2845
query76	2187	1169	744	744
query77	532	372	277	277
query78	10437	10171	9359	9359
query79	3505	800	582	582
query80	972	523	445	445
query81	548	274	236	236
query82	415	127	93	93
query83	181	163	149	149
query84	289	95	72	72
query85	774	383	300	300
query86	445	301	279	279
query87	4486	4641	4300	4300
query88	4701	2198	2158	2158
query89	415	334	290	290
query90	1671	188	187	187
query91	133	136	108	108
query92	75	57	58	57
query93	2890	990	588	588
query94	719	392	303	303
query95	345	263	265	263
query96	489	562	272	272
query97	2776	2880	2719	2719
query98	227	201	211	201
query99	1310	1404	1271	1271
Total cold run time: 294384 ms
Total hot run time: 190368 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 44.50% (11750/26405)
Line Coverage: 34.00% (98256/288948)
Region Coverage: 33.09% (50326/152106)
Branch Coverage: 28.74% (25303/88052)
Coverage Report: http://coverage.selectdb-in.cc/coverage/602b92f38c90511e8aa35ae9606ee41d4706b1f4_602b92f38c90511e8aa35ae9606ee41d4706b1f4/report/index.html

@doris-robot
Copy link

ClickBench: Total hot run time: 30.79 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 602b92f38c90511e8aa35ae9606ee41d4706b1f4, data reload: false

query1	0.04	0.06	0.03
query2	0.07	0.04	0.03
query3	0.24	0.07	0.06
query4	1.62	0.10	0.10
query5	0.41	0.41	0.40
query6	1.16	0.65	0.66
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.59	0.52	0.52
query10	0.56	0.58	0.56
query11	0.15	0.10	0.11
query12	0.14	0.12	0.11
query13	0.62	0.60	0.60
query14	2.67	2.75	2.73
query15	0.93	0.85	0.86
query16	0.39	0.39	0.37
query17	1.04	1.02	1.04
query18	0.22	0.19	0.20
query19	1.93	1.85	1.94
query20	0.01	0.01	0.01
query21	15.36	0.92	0.54
query22	0.76	1.17	0.61
query23	14.96	1.39	0.63
query24	7.09	2.02	0.95
query25	0.52	0.28	0.12
query26	0.60	0.15	0.13
query27	0.05	0.04	0.04
query28	10.03	0.86	0.42
query29	12.59	3.94	3.31
query30	0.25	0.09	0.06
query31	2.83	0.60	0.38
query32	3.22	0.54	0.46
query33	2.98	3.03	3.03
query34	15.77	5.19	4.56
query35	4.59	4.73	4.53
query36	0.70	0.49	0.49
query37	0.10	0.06	0.07
query38	0.05	0.05	0.04
query39	0.02	0.02	0.02
query40	0.17	0.14	0.12
query41	0.09	0.03	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.02
Total cold run time: 105.66 s
Total hot run time: 30.79 s

@Mryange
Copy link
Contributor Author

Mryange commented Feb 24, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 31664 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 602b92f38c90511e8aa35ae9606ee41d4706b1f4, data reload: false

------ Round 1 ----------------------------------
q1	17589	5319	5049	5049
q2	2053	307	171	171
q3	10397	1226	734	734
q4	10205	1012	527	527
q5	7538	2459	2281	2281
q6	181	166	132	132
q7	877	744	598	598
q8	9298	1352	1371	1352
q9	4892	4495	4722	4495
q10	6887	2307	1893	1893
q11	478	285	252	252
q12	338	353	215	215
q13	17767	3674	3099	3099
q14	233	243	207	207
q15	513	471	455	455
q16	616	627	589	589
q17	564	903	332	332
q18	6736	6384	6359	6359
q19	1217	951	560	560
q20	318	325	191	191
q21	2858	2112	1874	1874
q22	360	328	299	299
Total cold run time: 101915 ms
Total hot run time: 31664 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5088	5095	5087	5087
q2	236	328	240	240
q3	2184	2665	2315	2315
q4	1489	1833	1393	1393
q5	4197	4107	4103	4103
q6	212	161	125	125
q7	1846	1806	1643	1643
q8	2602	2560	2519	2519
q9	7179	7178	7117	7117
q10	2996	3218	2784	2784
q11	563	524	504	504
q12	675	786	626	626
q13	3508	3817	3343	3343
q14	286	292	272	272
q15	517	476	465	465
q16	643	700	637	637
q17	1125	1613	1316	1316
q18	7539	7381	7542	7381
q19	786	764	796	764
q20	1941	2122	1937	1937
q21	5405	5131	4613	4613
q22	633	553	549	549
Total cold run time: 51650 ms
Total hot run time: 49733 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 190967 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 602b92f38c90511e8aa35ae9606ee41d4706b1f4, data reload: false

query1	1313	946	978	946
query2	6209	1910	1847	1847
query3	11108	4540	4443	4443
query4	57078	25450	22953	22953
query5	5106	507	476	476
query6	399	193	185	185
query7	5227	513	302	302
query8	329	251	237	237
query9	6786	2753	2758	2753
query10	386	313	240	240
query11	15293	15357	14979	14979
query12	151	107	101	101
query13	1204	548	389	389
query14	10515	6646	6700	6646
query15	201	208	197	197
query16	6785	675	489	489
query17	1091	740	605	605
query18	915	389	317	317
query19	208	202	183	183
query20	128	127	130	127
query21	205	127	111	111
query22	4379	4530	4446	4446
query23	33936	33513	33309	33309
query24	5651	2453	2455	2453
query25	458	461	401	401
query26	679	292	159	159
query27	1707	500	366	366
query28	2982	2585	2531	2531
query29	537	580	438	438
query30	228	234	157	157
query31	916	891	800	800
query32	73	63	57	57
query33	470	370	309	309
query34	748	867	516	516
query35	809	829	770	770
query36	981	972	908	908
query37	119	97	79	79
query38	4396	4250	4248	4248
query39	1493	1424	1417	1417
query40	205	116	104	104
query41	51	51	49	49
query42	139	109	109	109
query43	501	531	490	490
query44	1412	865	847	847
query45	182	178	163	163
query46	902	1054	683	683
query47	1878	1899	1844	1844
query48	419	465	334	334
query49	717	549	440	440
query50	714	791	441	441
query51	4301	4481	4254	4254
query52	105	102	100	100
query53	230	266	188	188
query54	488	514	441	441
query55	91	91	86	86
query56	263	296	261	261
query57	1224	1217	1141	1141
query58	261	240	241	240
query59	2797	2844	2761	2761
query60	285	281	279	279
query61	122	132	121	121
query62	737	752	703	703
query63	233	204	198	198
query64	1547	1016	660	660
query65	3182	3109	3130	3109
query66	723	401	297	297
query67	15865	15527	15474	15474
query68	5385	792	516	516
query69	533	376	262	262
query70	1218	1102	1115	1102
query71	445	307	265	265
query72	5950	3625	3656	3625
query73	1009	742	373	373
query74	9228	9167	8685	8685
query75	3416	3144	2693	2693
query76	3774	1166	801	801
query77	547	360	281	281
query78	9934	9986	9344	9344
query79	2240	822	631	631
query80	636	537	508	508
query81	484	275	232	232
query82	627	119	93	93
query83	196	167	149	149
query84	291	92	67	67
query85	783	346	304	304
query86	420	300	275	275
query87	4478	4573	4444	4444
query88	3837	2375	2361	2361
query89	429	317	280	280
query90	1915	192	191	191
query91	135	134	107	107
query92	70	69	54	54
query93	1672	1013	574	574
query94	660	415	294	294
query95	345	265	250	250
query96	507	546	293	293
query97	2871	2813	2750	2750
query98	222	210	196	196
query99	1649	1399	1260	1260
Total cold run time: 296679 ms
Total hot run time: 190967 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.48 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 602b92f38c90511e8aa35ae9606ee41d4706b1f4, data reload: false

query1	0.03	0.04	0.03
query2	0.07	0.03	0.03
query3	0.23	0.07	0.06
query4	1.62	0.10	0.10
query5	0.41	0.43	0.39
query6	1.17	0.66	0.67
query7	0.03	0.02	0.02
query8	0.04	0.03	0.03
query9	0.59	0.51	0.53
query10	0.57	0.58	0.56
query11	0.16	0.11	0.10
query12	0.15	0.11	0.11
query13	0.62	0.60	0.60
query14	2.75	2.71	2.68
query15	0.93	0.86	0.85
query16	0.36	0.38	0.38
query17	1.02	1.02	1.05
query18	0.21	0.20	0.20
query19	1.87	1.91	1.99
query20	0.01	0.01	0.02
query21	15.36	0.92	0.55
query22	0.76	1.26	0.82
query23	14.75	1.38	0.62
query24	6.99	1.74	0.51
query25	0.46	0.15	0.07
query26	0.63	0.16	0.14
query27	0.06	0.05	0.04
query28	8.93	0.90	0.44
query29	12.57	3.94	3.29
query30	0.25	0.09	0.06
query31	2.81	0.57	0.39
query32	3.23	0.54	0.47
query33	2.95	3.08	2.98
query34	15.73	5.11	4.51
query35	4.55	4.58	4.55
query36	0.67	0.49	0.48
query37	0.09	0.07	0.06
query38	0.05	0.03	0.03
query39	0.03	0.02	0.02
query40	0.17	0.14	0.13
query41	0.09	0.03	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 104.05 s
Total hot run time: 30.48 s

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 44.50% (11750/26405)
Line Coverage: 34.01% (98261/288953)
Region Coverage: 33.09% (50331/152112)
Branch Coverage: 28.74% (25304/88054)
Coverage Report: http://coverage.selectdb-in.cc/coverage/602b92f38c90511e8aa35ae9606ee41d4706b1f4_602b92f38c90511e8aa35ae9606ee41d4706b1f4/report/index.html

@Mryange Mryange force-pushed the be-ut-vdata-stream-recvr branch from 602b92f to 58982d0 Compare February 24, 2025 03:52
@Mryange
Copy link
Contributor Author

Mryange commented Feb 24, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 31388 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 58982d083ca22e0c76f0d239741e810449ffa65f, data reload: false

------ Round 1 ----------------------------------
q1	17621	5407	5061	5061
q2	2053	298	163	163
q3	10432	1246	747	747
q4	10191	1019	520	520
q5	7518	2422	2332	2332
q6	186	175	134	134
q7	930	767	600	600
q8	9315	1313	1189	1189
q9	4841	4599	4714	4599
q10	6834	2327	1879	1879
q11	476	285	253	253
q12	344	370	217	217
q13	17763	3673	3081	3081
q14	227	247	217	217
q15	499	474	451	451
q16	589	612	596	596
q17	587	853	328	328
q18	6968	6257	6099	6099
q19	1210	964	539	539
q20	304	325	199	199
q21	2835	2129	1895	1895
q22	369	327	289	289
Total cold run time: 102092 ms
Total hot run time: 31388 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5128	5120	5142	5120
q2	234	331	224	224
q3	2186	2675	2302	2302
q4	1445	1823	1363	1363
q5	4246	4111	4120	4111
q6	209	164	133	133
q7	1860	1831	1684	1684
q8	2579	2564	2442	2442
q9	7241	7186	7221	7186
q10	3025	3272	2810	2810
q11	569	518	507	507
q12	687	765	655	655
q13	3422	3959	3283	3283
q14	272	299	273	273
q15	524	462	468	462
q16	650	675	669	669
q17	1144	1585	1366	1366
q18	7565	7423	7415	7415
q19	809	884	999	884
q20	1941	2052	1905	1905
q21	5453	5103	4761	4761
q22	616	546	585	546
Total cold run time: 51805 ms
Total hot run time: 50101 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 190331 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 58982d083ca22e0c76f0d239741e810449ffa65f, data reload: false

query1	1312	989	917	917
query2	6210	1832	1816	1816
query3	11139	4708	4488	4488
query4	56185	24441	23440	23440
query5	5204	506	494	494
query6	370	194	202	194
query7	5099	517	294	294
query8	327	243	241	241
query9	6250	2590	2596	2590
query10	426	326	249	249
query11	15115	15194	14902	14902
query12	169	108	104	104
query13	1133	517	398	398
query14	11018	6583	6794	6583
query15	205	200	179	179
query16	7061	668	472	472
query17	1083	745	589	589
query18	1485	428	322	322
query19	212	205	172	172
query20	130	130	122	122
query21	210	129	107	107
query22	4489	4664	4636	4636
query23	34216	33499	33353	33353
query24	5588	2439	2401	2401
query25	472	455	395	395
query26	690	296	166	166
query27	1694	527	331	331
query28	2832	2466	2432	2432
query29	545	578	431	431
query30	220	185	153	153
query31	889	866	808	808
query32	79	60	58	58
query33	463	358	294	294
query34	761	862	522	522
query35	795	847	757	757
query36	967	986	912	912
query37	119	97	74	74
query38	4242	4278	4324	4278
query39	1485	1438	1406	1406
query40	204	122	110	110
query41	51	49	51	49
query42	122	105	104	104
query43	493	530	469	469
query44	1318	803	808	803
query45	182	170	173	170
query46	893	1065	676	676
query47	1798	1840	1731	1731
query48	397	435	327	327
query49	689	530	440	440
query50	725	771	432	432
query51	4281	4273	4221	4221
query52	109	106	97	97
query53	228	259	188	188
query54	481	503	438	438
query55	80	85	78	78
query56	281	263	239	239
query57	1162	1199	1113	1113
query58	247	255	234	234
query59	2754	2872	2524	2524
query60	295	267	270	267
query61	133	127	119	119
query62	795	725	688	688
query63	235	200	199	199
query64	1456	983	698	698
query65	3230	3131	3159	3131
query66	715	383	291	291
query67	16051	15622	15430	15430
query68	5355	795	515	515
query69	518	318	258	258
query70	1205	1130	1113	1113
query71	440	308	267	267
query72	6304	3637	3703	3637
query73	1081	745	358	358
query74	9173	8949	8943	8943
query75	3435	3138	2639	2639
query76	3821	1166	738	738
query77	542	353	271	271
query78	10275	10205	9353	9353
query79	2052	797	617	617
query80	864	527	428	428
query81	526	271	238	238
query82	387	124	100	100
query83	191	168	154	154
query84	280	91	81	81
query85	729	349	315	315
query86	392	328	286	286
query87	4408	4479	4271	4271
query88	3081	2221	2197	2197
query89	385	321	289	289
query90	1885	189	194	189
query91	137	135	156	135
query92	76	60	52	52
query93	2720	980	564	564
query94	653	418	295	295
query95	349	264	254	254
query96	491	567	273	273
query97	2801	2863	2726	2726
query98	230	203	208	203
query99	1339	1421	1226	1226
Total cold run time: 296419 ms
Total hot run time: 190331 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.08 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 58982d083ca22e0c76f0d239741e810449ffa65f, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.03	0.03
query3	0.24	0.06	0.06
query4	1.63	0.09	0.10
query5	0.41	0.40	0.42
query6	1.13	0.67	0.66
query7	0.02	0.02	0.01
query8	0.04	0.04	0.03
query9	0.59	0.51	0.53
query10	0.57	0.57	0.57
query11	0.15	0.10	0.10
query12	0.14	0.10	0.11
query13	0.61	0.60	0.60
query14	2.71	2.68	2.72
query15	0.92	0.85	0.85
query16	0.36	0.39	0.37
query17	1.06	1.00	1.06
query18	0.21	0.20	0.19
query19	1.93	1.85	1.94
query20	0.01	0.01	0.01
query21	15.36	0.90	0.55
query22	0.75	1.24	0.67
query23	14.86	1.38	0.60
query24	6.89	1.32	1.34
query25	0.53	0.19	0.07
query26	0.59	0.17	0.14
query27	0.06	0.05	0.05
query28	10.29	0.86	0.43
query29	12.61	3.91	3.31
query30	0.25	0.08	0.06
query31	2.84	0.59	0.39
query32	3.22	0.56	0.46
query33	2.94	2.96	3.00
query34	15.80	5.18	4.61
query35	4.53	4.53	4.62
query36	0.65	0.49	0.48
query37	0.09	0.06	0.06
query38	0.05	0.03	0.04
query39	0.03	0.02	0.02
query40	0.17	0.14	0.13
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.04	0.04	0.03
Total cold run time: 105.5 s
Total hot run time: 31.08 s

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 44.49% (11748/26405)
Line Coverage: 34.00% (98235/288958)
Region Coverage: 33.09% (50334/152115)
Branch Coverage: 28.75% (25318/88056)
Coverage Report: http://coverage.selectdb-in.cc/coverage/58982d083ca22e0c76f0d239741e810449ffa65f_58982d083ca22e0c76f0d239741e810449ffa65f/report/index.html

@Mryange
Copy link
Contributor Author

Mryange commented Feb 24, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 31320 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 87ded34367f1bae595dda76623ff0a0db7846205, data reload: false

------ Round 1 ----------------------------------
q1	17632	5278	5082	5082
q2	2049	308	184	184
q3	10407	1329	715	715
q4	10277	1023	526	526
q5	8279	2471	2253	2253
q6	212	165	132	132
q7	889	747	616	616
q8	9296	1293	1192	1192
q9	4967	4519	4545	4519
q10	6835	2279	1882	1882
q11	471	279	262	262
q12	353	362	222	222
q13	17748	3651	3079	3079
q14	223	229	206	206
q15	515	445	464	445
q16	614	612	582	582
q17	587	865	344	344
q18	6686	6182	6090	6090
q19	1345	940	537	537
q20	311	329	199	199
q21	2753	2084	1945	1945
q22	363	331	308	308
Total cold run time: 102812 ms
Total hot run time: 31320 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5073	5119	5039	5039
q2	244	331	231	231
q3	2168	2654	2261	2261
q4	1363	1834	1340	1340
q5	4249	4132	4152	4132
q6	204	164	124	124
q7	1862	1803	1676	1676
q8	2595	2531	2524	2524
q9	7358	7105	7131	7105
q10	2959	3195	2764	2764
q11	587	524	493	493
q12	692	748	583	583
q13	3485	3854	3297	3297
q14	281	296	253	253
q15	519	475	467	467
q16	637	665	636	636
q17	1129	1545	1346	1346
q18	7604	7372	7167	7167
q19	762	804	847	804
q20	1965	2094	1888	1888
q21	5264	4874	4908	4874
q22	644	574	558	558
Total cold run time: 51644 ms
Total hot run time: 49562 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 183644 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 87ded34367f1bae595dda76623ff0a0db7846205, data reload: false

query1	966	367	372	367
query2	6524	1866	1789	1789
query3	6795	206	209	206
query4	26211	23749	23193	23193
query5	4284	650	490	490
query6	308	198	187	187
query7	4609	495	293	293
query8	300	241	244	241
query9	8626	2571	2559	2559
query10	472	317	254	254
query11	15479	15073	14858	14858
query12	152	109	109	109
query13	1672	516	415	415
query14	8984	6593	6382	6382
query15	214	201	177	177
query16	7308	624	470	470
query17	1207	704	552	552
query18	1804	397	302	302
query19	207	196	155	155
query20	120	114	115	114
query21	204	122	104	104
query22	4342	4532	4443	4443
query23	34365	33499	32854	32854
query24	7696	2356	2376	2356
query25	537	457	399	399
query26	1222	264	153	153
query27	2117	493	320	320
query28	3903	2394	2369	2369
query29	720	552	411	411
query30	233	189	147	147
query31	939	835	797	797
query32	73	59	61	59
query33	551	371	304	304
query34	768	839	504	504
query35	820	813	735	735
query36	968	985	912	912
query37	117	97	69	69
query38	4265	4126	4057	4057
query39	1452	1419	1414	1414
query40	207	111	103	103
query41	53	56	50	50
query42	122	110	101	101
query43	484	503	474	474
query44	1257	776	775	775
query45	178	167	156	156
query46	849	1025	631	631
query47	1766	1758	1744	1744
query48	378	411	297	297
query49	783	504	398	398
query50	687	742	429	429
query51	4107	4224	4139	4139
query52	99	103	92	92
query53	219	255	185	185
query54	496	473	401	401
query55	83	82	78	78
query56	253	270	251	251
query57	1120	1141	1058	1058
query58	235	237	233	233
query59	2628	2822	2544	2544
query60	266	266	262	262
query61	123	114	118	114
query62	780	713	668	668
query63	231	187	193	187
query64	4438	992	655	655
query65	3200	3127	3130	3127
query66	1134	386	296	296
query67	15725	15501	15515	15501
query68	4963	766	581	581
query69	444	312	259	259
query70	1228	1169	1113	1113
query71	396	284	263	263
query72	5711	3635	3739	3635
query73	698	733	355	355
query74	9094	9101	8968	8968
query75	3110	3135	2682	2682
query76	2920	1157	736	736
query77	361	351	276	276
query78	9969	10022	9310	9310
query79	2178	813	605	605
query80	634	524	472	472
query81	513	275	253	253
query82	350	127	99	99
query83	185	170	156	156
query84	246	91	68	68
query85	739	349	307	307
query86	376	307	269	269
query87	4511	4521	4283	4283
query88	3640	2237	2213	2213
query89	378	310	302	302
query90	2075	200	188	188
query91	134	135	113	113
query92	80	63	103	63
query93	2482	991	560	560
query94	661	407	294	294
query95	352	262	271	262
query96	497	542	280	280
query97	2740	2843	2746	2746
query98	224	211	208	208
query99	1275	1416	1256	1256
Total cold run time: 266599 ms
Total hot run time: 183644 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.33 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 87ded34367f1bae595dda76623ff0a0db7846205, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.24	0.07	0.07
query4	1.62	0.11	0.10
query5	0.42	0.41	0.41
query6	1.17	0.67	0.65
query7	0.02	0.02	0.02
query8	0.04	0.04	0.03
query9	0.60	0.53	0.54
query10	0.55	0.58	0.57
query11	0.15	0.10	0.10
query12	0.14	0.11	0.11
query13	0.62	0.59	0.60
query14	2.74	2.70	2.69
query15	0.92	0.84	0.85
query16	0.37	0.36	0.38
query17	1.06	0.98	1.02
query18	0.21	0.19	0.19
query19	1.91	1.81	1.98
query20	0.01	0.01	0.01
query21	15.36	0.88	0.54
query22	0.76	1.15	0.62
query23	14.97	1.38	0.63
query24	7.17	1.46	0.74
query25	0.49	0.34	0.21
query26	0.48	0.16	0.12
query27	0.05	0.05	0.05
query28	10.13	0.88	0.42
query29	12.56	3.89	3.23
query30	0.26	0.09	0.06
query31	2.82	0.60	0.38
query32	3.24	0.54	0.47
query33	3.04	3.04	2.98
query34	15.69	5.17	4.46
query35	4.52	4.50	4.52
query36	0.66	0.50	0.49
query37	0.09	0.06	0.06
query38	0.06	0.04	0.04
query39	0.04	0.02	0.03
query40	0.17	0.13	0.13
query41	0.08	0.03	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.02
Total cold run time: 105.61 s
Total hot run time: 30.33 s

@Mryange Mryange force-pushed the be-ut-vdata-stream-recvr branch from 87ded34 to ba694d7 Compare February 24, 2025 08:55
@Mryange Mryange force-pushed the be-ut-vdata-stream-recvr branch from ba694d7 to 93efb82 Compare February 24, 2025 09:41
@Mryange
Copy link
Contributor Author

Mryange commented Feb 24, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 31733 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 93efb82c4bffe183e3444e588611d480ec2afb8f, data reload: false

------ Round 1 ----------------------------------
q1	17600	5370	5140	5140
q2	2052	297	166	166
q3	10576	1369	757	757
q4	10314	1084	551	551
q5	8851	2492	2333	2333
q6	214	178	137	137
q7	920	752	624	624
q8	9289	1344	1157	1157
q9	4867	4572	4638	4572
q10	6837	2330	1901	1901
q11	472	283	260	260
q12	352	366	221	221
q13	17775	3703	3161	3161
q14	228	225	214	214
q15	516	488	463	463
q16	627	617	580	580
q17	576	882	333	333
q18	6791	6222	6146	6146
q19	1207	976	557	557
q20	310	321	202	202
q21	2863	2108	1950	1950
q22	360	339	308	308
Total cold run time: 103597 ms
Total hot run time: 31733 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5151	5223	5135	5135
q2	235	334	229	229
q3	2157	2689	2334	2334
q4	1396	1820	1382	1382
q5	4246	4123	4171	4123
q6	216	168	126	126
q7	1832	1838	1772	1772
q8	2600	2675	2598	2598
q9	7195	7180	7093	7093
q10	3028	3230	2747	2747
q11	588	517	489	489
q12	674	782	585	585
q13	3500	3933	3197	3197
q14	272	289	270	270
q15	515	461	474	461
q16	648	673	654	654
q17	1133	1625	1353	1353
q18	7554	7431	7305	7305
q19	788	875	987	875
q20	2000	1986	1862	1862
q21	5903	4920	5010	4920
q22	678	601	549	549
Total cold run time: 52309 ms
Total hot run time: 50059 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 184884 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 93efb82c4bffe183e3444e588611d480ec2afb8f, data reload: false

query1	996	413	373	373
query2	6525	1826	1797	1797
query3	6797	216	208	208
query4	26475	24032	23726	23726
query5	4318	673	515	515
query6	303	193	194	193
query7	4602	524	312	312
query8	304	248	232	232
query9	8651	2576	2585	2576
query10	482	304	257	257
query11	15771	15049	14976	14976
query12	155	109	101	101
query13	1651	510	417	417
query14	9670	6906	6329	6329
query15	211	203	185	185
query16	7284	640	471	471
query17	1190	726	561	561
query18	1970	409	307	307
query19	196	193	162	162
query20	133	116	115	115
query21	210	123	103	103
query22	4071	4445	4627	4445
query23	34428	33386	33085	33085
query24	7748	2415	2456	2415
query25	559	474	413	413
query26	1224	280	155	155
query27	2135	489	339	339
query28	3882	2419	2392	2392
query29	773	580	473	473
query30	230	180	149	149
query31	952	853	794	794
query32	78	73	62	62
query33	554	340	285	285
query34	783	838	515	515
query35	798	810	743	743
query36	987	985	891	891
query37	122	96	73	73
query38	4211	4188	4280	4188
query39	1418	1400	1389	1389
query40	200	109	105	105
query41	52	52	50	50
query42	172	104	113	104
query43	503	498	488	488
query44	1292	773	773	773
query45	174	169	161	161
query46	874	1045	643	643
query47	1735	1794	1714	1714
query48	390	410	310	310
query49	769	502	411	411
query50	680	766	419	419
query51	4192	4212	4107	4107
query52	113	105	95	95
query53	230	257	185	185
query54	485	497	417	417
query55	78	78	77	77
query56	251	269	258	258
query57	1124	1125	1075	1075
query58	250	234	235	234
query59	2649	2541	2490	2490
query60	295	277	254	254
query61	118	119	117	117
query62	788	742	668	668
query63	233	198	199	198
query64	4411	1001	701	701
query65	3241	3187	3153	3153
query66	1122	404	308	308
query67	15726	15542	15304	15304
query68	6474	760	520	520
query69	484	306	263	263
query70	1146	1154	1137	1137
query71	411	285	273	273
query72	5710	3578	3722	3578
query73	760	745	369	369
query74	9291	9096	9273	9096
query75	3157	3178	2711	2711
query76	3213	1172	727	727
query77	475	382	293	293
query78	10133	10288	9279	9279
query79	1512	940	610	610
query80	640	552	464	464
query81	492	272	236	236
query82	234	128	98	98
query83	179	166	158	158
query84	239	93	80	80
query85	765	366	316	316
query86	332	317	274	274
query87	4492	4513	4377	4377
query88	2948	2239	2231	2231
query89	381	331	280	280
query90	1772	205	195	195
query91	142	158	106	106
query92	63	59	57	57
query93	1175	1011	573	573
query94	603	414	297	297
query95	353	268	270	268
query96	511	533	281	281
query97	2740	2872	2734	2734
query98	220	202	205	202
query99	1331	1410	1260	1260
Total cold run time: 267372 ms
Total hot run time: 184884 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.85 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 93efb82c4bffe183e3444e588611d480ec2afb8f, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.04	0.03
query3	0.24	0.06	0.06
query4	1.63	0.10	0.11
query5	0.42	0.41	0.41
query6	1.16	0.66	0.66
query7	0.02	0.02	0.01
query8	0.05	0.04	0.03
query9	0.60	0.52	0.52
query10	0.56	0.58	0.57
query11	0.14	0.10	0.11
query12	0.14	0.11	0.11
query13	0.63	0.60	0.59
query14	2.66	2.75	2.70
query15	0.92	0.85	0.84
query16	0.38	0.38	0.39
query17	1.04	1.07	1.01
query18	0.22	0.19	0.19
query19	1.94	1.83	1.99
query20	0.02	0.01	0.02
query21	15.34	0.92	0.56
query22	0.75	1.29	0.74
query23	14.75	1.33	0.62
query24	6.77	1.92	0.95
query25	0.46	0.32	0.13
query26	0.57	0.16	0.13
query27	0.06	0.05	0.05
query28	9.38	0.83	0.43
query29	12.53	3.96	3.28
query30	0.25	0.08	0.06
query31	2.82	0.59	0.38
query32	3.23	0.55	0.46
query33	2.96	2.99	3.02
query34	15.80	5.21	4.57
query35	4.58	4.52	4.59
query36	0.65	0.49	0.48
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.02	0.02	0.02
query40	0.17	0.14	0.13
query41	0.09	0.02	0.02
query42	0.04	0.02	0.03
query43	0.04	0.03	0.03
Total cold run time: 104.27 s
Total hot run time: 30.85 s

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 44.50% (11750/26404)
Line Coverage: 34.00% (98254/288942)
Region Coverage: 33.08% (50315/152095)
Branch Coverage: 28.73% (25291/88040)
Coverage Report: http://coverage.selectdb-in.cc/coverage/93efb82c4bffe183e3444e588611d480ec2afb8f_93efb82c4bffe183e3444e588611d480ec2afb8f/report/index.html

@Mryange
Copy link
Contributor Author

Mryange commented Feb 24, 2025

run buildall

@Mryange Mryange marked this pull request as ready for review February 24, 2025 12:09
@doris-robot
Copy link

TPC-H: Total hot run time: 31420 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit def914c9aa22b7e299252093d022bb5629a3ac94, data reload: false

------ Round 1 ----------------------------------
q1	17682	5550	5062	5062
q2	2055	294	176	176
q3	10411	1279	717	717
q4	10209	1005	524	524
q5	7552	2418	2300	2300
q6	185	166	133	133
q7	915	734	623	623
q8	9319	1294	1182	1182
q9	4847	4795	4582	4582
q10	6846	2305	1894	1894
q11	499	285	271	271
q12	351	366	225	225
q13	17791	3725	3117	3117
q14	234	227	216	216
q15	501	470	458	458
q16	622	615	586	586
q17	587	855	334	334
q18	6743	6131	6106	6106
q19	1357	974	559	559
q20	321	322	190	190
q21	2750	2145	1873	1873
q22	355	328	292	292
Total cold run time: 102132 ms
Total hot run time: 31420 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5162	5134	5140	5134
q2	231	341	238	238
q3	2158	2720	2317	2317
q4	1395	1839	1383	1383
q5	4235	4130	4146	4130
q6	203	163	122	122
q7	1852	1861	1643	1643
q8	2664	2655	2523	2523
q9	7330	7123	7194	7123
q10	2987	3191	2825	2825
q11	591	515	473	473
q12	671	734	635	635
q13	3562	3977	3319	3319
q14	270	302	272	272
q15	512	450	460	450
q16	625	681	644	644
q17	1146	1490	1397	1397
q18	7520	7195	7358	7195
q19	809	768	945	768
q20	1972	2013	1927	1927
q21	5501	4883	4806	4806
q22	640	609	536	536
Total cold run time: 52036 ms
Total hot run time: 49860 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 182811 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit def914c9aa22b7e299252093d022bb5629a3ac94, data reload: false

query1	961	374	388	374
query2	6514	1819	1844	1819
query3	6787	213	204	204
query4	26304	23939	23458	23458
query5	4369	699	478	478
query6	271	187	189	187
query7	4603	498	290	290
query8	278	231	219	219
query9	8867	2546	2532	2532
query10	472	311	243	243
query11	15639	15125	14838	14838
query12	153	107	107	107
query13	1656	532	388	388
query14	9052	6656	6109	6109
query15	210	189	179	179
query16	7170	635	482	482
query17	1174	693	532	532
query18	1942	404	282	282
query19	194	175	146	146
query20	125	119	109	109
query21	205	122	99	99
query22	4107	4278	4060	4060
query23	33909	32783	32935	32783
query24	7680	2363	2385	2363
query25	508	457	375	375
query26	1241	273	165	165
query27	2470	459	342	342
query28	4250	2386	2378	2378
query29	735	556	410	410
query30	234	183	156	156
query31	944	827	780	780
query32	78	67	64	64
query33	596	353	297	297
query34	766	831	497	497
query35	779	818	734	734
query36	969	987	890	890
query37	113	96	78	78
query38	4266	4092	4149	4092
query39	1596	1389	1401	1389
query40	208	118	101	101
query41	55	54	51	51
query42	119	104	102	102
query43	484	499	455	455
query44	1302	786	758	758
query45	181	166	160	160
query46	877	1083	636	636
query47	1737	1779	1672	1672
query48	401	435	307	307
query49	785	497	413	413
query50	706	721	418	418
query51	4220	4158	4145	4145
query52	107	110	95	95
query53	229	263	190	190
query54	477	497	429	429
query55	80	78	78	78
query56	264	255	255	255
query57	1149	1097	1043	1043
query58	238	230	235	230
query59	2477	2668	2610	2610
query60	290	264	251	251
query61	119	115	114	114
query62	783	738	660	660
query63	232	195	188	188
query64	4252	1028	755	755
query65	3225	3217	3116	3116
query66	1157	428	318	318
query67	15835	15847	15226	15226
query68	2406	807	562	562
query69	429	319	276	276
query70	1229	1144	1147	1144
query71	360	308	268	268
query72	5796	3703	3799	3703
query73	641	761	363	363
query74	8933	9141	8776	8776
query75	3118	3162	2688	2688
query76	2200	1162	739	739
query77	344	380	284	284
query78	10066	10461	9275	9275
query79	2098	857	607	607
query80	1601	535	448	448
query81	543	284	241	241
query82	503	128	98	98
query83	258	177	146	146
query84	246	101	81	81
query85	778	349	306	306
query86	377	309	285	285
query87	4511	4572	4311	4311
query88	3088	2263	2202	2202
query89	405	328	280	280
query90	1817	192	195	192
query91	135	143	109	109
query92	64	63	58	58
query93	1190	1003	573	573
query94	658	395	307	307
query95	356	273	260	260
query96	510	539	274	274
query97	2769	2848	2757	2757
query98	225	207	204	204
query99	1267	1397	1290	1290
Total cold run time: 263097 ms
Total hot run time: 182811 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.35 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit def914c9aa22b7e299252093d022bb5629a3ac94, data reload: false

query1	0.03	0.05	0.03
query2	0.06	0.03	0.03
query3	0.23	0.06	0.07
query4	1.59	0.10	0.10
query5	0.42	0.42	0.41
query6	1.17	0.68	0.66
query7	0.02	0.01	0.01
query8	0.04	0.03	0.03
query9	0.59	0.52	0.52
query10	0.57	0.58	0.57
query11	0.15	0.11	0.11
query12	0.15	0.11	0.10
query13	0.64	0.60	0.61
query14	2.67	2.70	2.73
query15	0.91	0.86	0.85
query16	0.38	0.36	0.36
query17	1.04	1.06	1.05
query18	0.21	0.20	0.19
query19	1.96	1.84	2.02
query20	0.02	0.01	0.02
query21	15.36	0.92	0.55
query22	0.75	1.19	0.68
query23	14.96	1.40	0.61
query24	7.51	1.60	0.48
query25	0.52	0.22	0.08
query26	0.63	0.17	0.13
query27	0.05	0.05	0.05
query28	9.13	0.91	0.44
query29	12.62	3.98	3.28
query30	0.27	0.11	0.05
query31	2.81	0.58	0.38
query32	3.23	0.55	0.47
query33	3.03	3.05	3.09
query34	15.85	5.21	4.54
query35	4.57	4.53	4.56
query36	0.66	0.48	0.48
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.02
query40	0.17	0.13	0.13
query41	0.08	0.03	0.02
query42	0.04	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 105.29 s
Total hot run time: 30.35 s

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 44.51% (11753/26404)
Line Coverage: 34.03% (98323/288942)
Region Coverage: 33.13% (50386/152106)
Branch Coverage: 28.78% (25342/88040)
Coverage Report: http://coverage.selectdb-in.cc/coverage/def914c9aa22b7e299252093d022bb5629a3ac94_def914c9aa22b7e299252093d022bb5629a3ac94/report/index.html

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 25, 2025
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@BiteTheDDDDt BiteTheDDDDt merged commit 21ef822 into apache:master Feb 25, 2025
27 of 30 checks passed
Gabriel39 pushed a commit that referenced this pull request Feb 26, 2025
…k_ptr" thrown" in DataStreamRecvrTest (#48319)

There are conflicts between the following two PRs. 
One PR uses unique_ptr to construct query_ctx, while the other PR uses
shared_from_this

#48188
#47462
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants