Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](beut) fix "unknown file C++ exception with description "bad_weak_ptr" thrown" in DataStreamRecvrTest #48319

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

Mryange
Copy link
Contributor

@Mryange Mryange commented Feb 25, 2025

What problem does this PR solve?

There are conflicts between the following two PRs.
One PR uses unique_ptr to construct query_ctx, while the other PR uses shared_from_this

#48188
#47462

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Mryange
Copy link
Contributor Author

Mryange commented Feb 25, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 31845 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3e991d28710373365f6e694bd17f8c259b777b6d, data reload: false

------ Round 1 ----------------------------------
q1	17603	5284	5213	5213
q2	2045	287	164	164
q3	10446	1212	761	761
q4	10294	1002	521	521
q5	8162	2393	2309	2309
q6	190	171	140	140
q7	889	743	594	594
q8	9316	1242	1048	1048
q9	4796	4735	4828	4735
q10	6820	2304	1894	1894
q11	473	275	273	273
q12	353	362	221	221
q13	17776	3663	3081	3081
q14	234	221	217	217
q15	527	471	455	455
q16	628	603	591	591
q17	577	856	351	351
q18	6587	6307	6292	6292
q19	1644	942	547	547
q20	306	310	197	197
q21	2656	2123	1940	1940
q22	370	340	301	301
Total cold run time: 102692 ms
Total hot run time: 31845 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5235	5195	5238	5195
q2	236	330	229	229
q3	2235	2757	2369	2369
q4	1460	1871	1373	1373
q5	4306	4195	4133	4133
q6	208	164	125	125
q7	1861	1808	1739	1739
q8	2625	2621	2555	2555
q9	7195	7171	7166	7166
q10	3008	3205	2788	2788
q11	581	525	492	492
q12	693	778	637	637
q13	3402	3921	3334	3334
q14	282	318	278	278
q15	514	461	460	460
q16	620	678	638	638
q17	1119	1602	1354	1354
q18	7554	7332	7246	7246
q19	788	804	869	804
q20	1959	2038	1872	1872
q21	5512	5059	4819	4819
q22	658	592	554	554
Total cold run time: 52051 ms
Total hot run time: 50160 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 191219 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3e991d28710373365f6e694bd17f8c259b777b6d, data reload: false

query1	1303	952	912	912
query2	6205	1840	1847	1840
query3	10987	4387	4540	4387
query4	53022	25562	23605	23605
query5	5201	621	477	477
query6	331	192	185	185
query7	4880	522	289	289
query8	302	244	241	241
query9	5526	2543	2534	2534
query10	400	294	255	255
query11	15139	15072	14881	14881
query12	158	108	108	108
query13	1028	509	382	382
query14	10343	6932	6819	6819
query15	196	194	181	181
query16	7074	672	469	469
query17	1118	729	566	566
query18	1504	413	334	334
query19	209	189	159	159
query20	120	115	128	115
query21	222	129	112	112
query22	4422	4445	4296	4296
query23	34105	33467	33415	33415
query24	5816	2428	2485	2428
query25	477	473	408	408
query26	670	278	159	159
query27	1713	501	344	344
query28	2746	2465	2416	2416
query29	588	560	434	434
query30	212	193	168	168
query31	890	867	821	821
query32	92	65	65	65
query33	478	383	319	319
query34	753	887	510	510
query35	825	844	755	755
query36	944	996	901	901
query37	131	103	78	78
query38	4146	4151	4136	4136
query39	1642	1486	1465	1465
query40	222	123	117	117
query41	57	62	58	58
query42	127	107	115	107
query43	510	522	497	497
query44	1350	822	826	822
query45	184	178	170	170
query46	894	1071	671	671
query47	1850	1868	1778	1778
query48	405	451	313	313
query49	717	542	436	436
query50	747	768	425	425
query51	4298	4290	4245	4245
query52	110	107	99	99
query53	234	265	195	195
query54	490	489	422	422
query55	84	87	81	81
query56	269	292	282	282
query57	1166	1168	1118	1118
query58	259	251	244	244
query59	2757	2804	2674	2674
query60	281	277	275	275
query61	116	146	143	143
query62	787	761	716	716
query63	229	193	195	193
query64	1453	1049	703	703
query65	3291	3320	3231	3231
query66	781	416	329	329
query67	16075	15520	15348	15348
query68	7021	877	518	518
query69	533	304	283	283
query70	1202	1082	1122	1082
query71	500	299	277	277
query72	5786	3648	3772	3648
query73	1466	768	355	355
query74	9085	9271	8918	8918
query75	3895	3197	2755	2755
query76	4344	1174	755	755
query77	647	367	291	291
query78	10205	9952	9131	9131
query79	2393	877	613	613
query80	618	520	454	454
query81	524	284	248	248
query82	631	125	94	94
query83	178	179	154	154
query84	287	94	76	76
query85	852	364	319	319
query86	384	288	288	288
query87	4463	4436	4272	4272
query88	3733	2209	2192	2192
query89	407	329	277	277
query90	1797	200	196	196
query91	135	142	110	110
query92	78	61	58	58
query93	1748	1049	593	593
query94	669	412	296	296
query95	358	277	256	256
query96	480	557	267	267
query97	3369	3423	3319	3319
query98	224	218	204	204
query99	1478	1426	1259	1259
Total cold run time: 295151 ms
Total hot run time: 191219 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 44.76% (11933/26658)
Line Coverage: 34.22% (99880/291906)
Region Coverage: 33.37% (51104/153165)
Branch Coverage: 28.92% (25663/88746)
Coverage Report: http://coverage.selectdb-in.cc/coverage/3e991d28710373365f6e694bd17f8c259b777b6d_3e991d28710373365f6e694bd17f8c259b777b6d/report/index.html
Increment Report: http://coverage.selectdb-in.cc/coverage/3e991d28710373365f6e694bd17f8c259b777b6d_3e991d28710373365f6e694bd17f8c259b777b6d/increment_report/index.html

@doris-robot
Copy link

ClickBench: Total hot run time: 30.7 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3e991d28710373365f6e694bd17f8c259b777b6d, data reload: false

query1	0.03	0.03	0.04
query2	0.07	0.04	0.03
query3	0.25	0.07	0.06
query4	1.60	0.10	0.10
query5	0.57	0.57	0.55
query6	1.21	0.73	0.72
query7	0.02	0.02	0.02
query8	0.04	0.03	0.04
query9	0.58	0.54	0.53
query10	0.57	0.58	0.57
query11	0.16	0.10	0.10
query12	0.14	0.11	0.14
query13	0.62	0.61	0.61
query14	2.79	2.71	2.67
query15	0.93	0.86	0.86
query16	0.38	0.37	0.39
query17	1.04	1.06	1.01
query18	0.22	0.21	0.20
query19	1.91	1.79	1.96
query20	0.01	0.02	0.01
query21	15.37	0.91	0.56
query22	0.75	1.24	0.63
query23	14.93	1.42	0.65
query24	7.64	1.64	0.56
query25	0.52	0.17	0.23
query26	0.60	0.18	0.14
query27	0.06	0.04	0.05
query28	9.16	0.86	0.43
query29	12.54	3.97	3.27
query30	0.25	0.09	0.06
query31	2.82	0.59	0.38
query32	3.23	0.56	0.46
query33	3.01	3.13	3.10
query34	15.76	5.13	4.54
query35	4.61	4.53	4.55
query36	0.67	0.50	0.50
query37	0.09	0.07	0.06
query38	0.05	0.04	0.03
query39	0.03	0.02	0.02
query40	0.17	0.13	0.13
query41	0.09	0.03	0.02
query42	0.04	0.02	0.03
query43	0.04	0.03	0.03
Total cold run time: 105.57 s
Total hot run time: 30.7 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 25, 2025
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@Gabriel39 Gabriel39 merged commit 10fbaf0 into apache:master Feb 26, 2025
31 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants