Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.18] OCPBUGS-48434: UPSTREAM distribution/distribution: 4190 fix: use http.DefaultTransport in S3 client #50

Open
wants to merge 1 commit into
base: release-4.18
Choose a base branch
from
Open

[release-4.18] OCPBUGS-48434: UPSTREAM distribution/distribution: 4190 fix: use http.DefaultTransport in S3 client #50

wants to merge 1 commit into from

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #44

/assign kaovilai

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 15, 2025
Merged
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-25981 has been cloned as Jira Issue OCPBUGS-48434. Will retitle bug to link to clone.
/retitle [release-4.18] OCPBUGS-48434: UPSTREAM distribution/distribution: 4190 fix: use http.DefaultTransport in S3 client

In response to this:

This is an automated cherry-pick of #44

/assign kaovilai

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.18] OCPBUGS-25981: UPSTREAM distribution/distribution: 4190 fix: use http.DefaultTransport in S3 client [release-4.18] OCPBUGS-48434: UPSTREAM distribution/distribution: 4190 fix: use http.DefaultTransport in S3 client Jan 15, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 15, 2025
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-48434, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-25981 to target a version in 4.19.0, but it targets "4.19" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #44

/assign kaovilai

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@flavianmissi
Copy link
Member

/lgtm

can you create a PR on openshift/image-registry vendoring the code from this one so we can see that the tests pass as expected @kaovilai?
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 27, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flavianmissi, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2025
kaovilai added a commit to kaovilai/image-registry that referenced this pull request Jan 27, 2025
@kaovilai
Test PR for openshift/docker-distribution#50
45eb4e3 
```
❯ go mod edit -replace=github.com/distribution/distribution/v3=github.com/openshift-cherrypick-robot/docker-distribution/[email protected]

~/git/image-registry docker-distribution-50*
❯ go mod tidy

~/git/image-registry docker-distribution-50*
❯ go mod vendor
```

Signed-off-by: Tiger Kaovilai <[email protected]>
kaovilai added a commit to kaovilai/image-registry that referenced this pull request Jan 27, 2025
@kaovilai
Test PR for openshift/docker-distribution#50
356caa0 
```
❯ go mod edit -replace=github.com/distribution/distribution/v3=github.com/openshift-cherrypick-robot/docker-distribution/[email protected]

~/git/image-registry docker-distribution-50*
❯ go mod tidy

~/git/image-registry docker-distribution-50*
❯ go mod vendor
```

Signed-off-by: Tiger Kaovilai <[email protected]>
@kaovilai kaovilai mentioned this pull request Jan 27, 2025
Open
@kaovilai
Copy link
Member

@flavianmissi done: openshift/image-registry#420

@flavianmissi
Copy link
Member

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 28, 2025
@flavianmissi
Copy link
Member

/jira refresh

@openshift-ci-robot
Copy link

@flavianmissi: This pull request references Jira Issue OCPBUGS-48434, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@flavianmissi
Copy link
Member

@kaovilai can you write some release note text in the bug? :)

@kaovilai
Copy link
Member

Boss said to leave this work behind for a bit will pick back up several weeks later probably :/

@flavianmissi
Copy link
Member

I'll put this on hold to reflect that, @kaovilai. You can remove the hold when you're ready to move forward.

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 28, 2025
@kaovilai
Copy link
Member

/cc @mpryc

@openshift-ci openshift-ci bot requested a review from mpryc January 30, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

@flavianmissi flavianmissi Awaiting requested review from flavianmissi

@mpryc mpryc Awaiting requested review from mpryc

Assignees

@flavianmissi flavianmissi

@kaovilai kaovilai

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@openshift-cherrypick-robot @openshift-ci-robot @flavianmissi @kaovilai @milosgajdos