Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test PR for docker-distribution/pull/50 #420

Open
wants to merge 1 commit into
base: release-4.18
Choose a base branch
from
Open

Test PR for docker-distribution/pull/50 #420

wants to merge 1 commit into from

Conversation

kaovilai
Copy link
Member

@kaovilai kaovilai commented Jan 27, 2025 •
edited
Loading

openshift/docker-distribution#50

❯ go mod edit -replace=github.com/distribution/distribution/v3=github.com/openshift-cherrypick-robot/docker-distribution/[email protected]

~/git/image-registry docker-distribution-50*
❯ go mod tidy

~/git/image-registry docker-distribution-50*
❯ go mod vendor

Signed-off-by: Tiger Kaovilai [email protected]

@kaovilai kaovilai changed the title Test PR for https://github.com/openshift/docker-distribution/pull/50 ``` ❯ go mod edit -replace=github.com/distribution/distribution/v3=github.com/openshift-cherrypick-robot/docker-distribution/[email protected] Test PR for https://github.com/openshift/docker-distribution/pull/50 Jan 27, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 27, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kaovilai
Once this PR has been reviewed and has the lgtm label, please assign bparees for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kaovilai
Test PR for openshift/docker-distribution#50
356caa0 
```
❯ go mod edit -replace=github.com/distribution/distribution/v3=github.com/openshift-cherrypick-robot/docker-distribution/[email protected]

~/git/image-registry docker-distribution-50*
❯ go mod tidy

~/git/image-registry docker-distribution-50*
❯ go mod vendor
```

Signed-off-by: Tiger Kaovilai <[email protected]>
@kaovilai kaovilai force-pushed the docker-distribution-50 branch from 45eb4e3 to 356caa0 Compare January 27, 2025 22:05
@kaovilai kaovilai changed the title Test PR for https://github.com/openshift/docker-distribution/pull/50 Test PR for docker-distribution/pull/50 Jan 27, 2025
@kaovilai kaovilai mentioned this pull request Jan 27, 2025
Open
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 28, 2025

@kaovilai: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 356caa0 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@flavianmissi
Copy link
Member

Nice! Test failure is unrelated.

I'll put this on hold since it needs to be updated after the docker-distribution PR merges, but it looks great.

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 28, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 6, 2025
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

@gabemontero gabemontero Awaiting requested review from gabemontero

Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaovilai @flavianmissi @openshift-merge-robot